Bug 119676

Summary: Move some Document recalcStyle code to StyleResolveTree
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, kangil.han, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch kling: review+

Antti Koivisto
Reported 2013-08-12 03:10:32 PDT
This is the usual starting point for tree resolve.
Attachments
patch (4.53 KB, patch)
2013-08-12 03:14 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-08-12 03:14:40 PDT
Created attachment 208524 [details] patch
Andreas Kling
Comment 2 2013-08-12 03:19:30 PDT
Comment on attachment 208524 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=208524&action=review r=me > Source/WebCore/style/StyleResolveTree.cpp:299 > + for (Node* child = document->firstChild(); child; child = child->nextSibling()) { > + if (!child->isElementNode()) > + continue; > + Element* elementChild = toElement(child); We should make ElementTraversal support this case.
Antti Koivisto
Comment 3 2013-08-12 03:24:38 PDT
http://trac.webkit.org/changeset/153938
Note You need to log in before you can comment on or make changes to this bug.