Bug 119673

Summary: [GTK] Remove Gail dependency from build system for GTK3
Product: WebKit Reporter: Mario Sanchez Prada <mario>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, dpranke, glenn, gtk-ews, gustavo, gyuyoung.kim, mrobinson, rakuco, rego+ews, xan.lopez, zan
Priority: P2 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 114867    
Bug Blocks:    
Attachments:
Description Flags
Patch proposal
gtk-ews: commit-queue-
Patch proposal gustavo: review+, commit-queue: commit-queue-

Mario Sanchez Prada
Reported 2013-08-12 02:20:43 PDT
Once bug 114867 is fixed, we won't longer need to compile and link against libgail anymore, so let's remove it from the build system.
Attachments
Patch proposal (14.30 KB, patch)
2013-08-12 02:59 PDT, Mario Sanchez Prada 		gtk-ews: commit-queue-
DetailsFormatted DiffDiff
Patch proposal (14.97 KB, patch)
2013-09-11 05:21 PDT, Mario Sanchez Prada 		gustavo: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2013-08-12 02:27:06 PDT
Setting proper dependency path and adding people on CC who might be interested
Mario Sanchez Prada
Comment 2 2013-08-12 02:59:39 PDT
Created attachment 208522 [details] Patch proposal One dependency less!
kov's GTK+ EWS bot
Comment 3 2013-08-12 05:12:15 PDT
Comment on attachment 208522 [details] Patch proposal Attachment 208522 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1449136
Build Bot
Comment 4 2013-08-23 14:05:37 PDT
Comment on attachment 208522 [details] Patch proposal Attachment 208522 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1527697
Mario Sanchez Prada
Comment 5 2013-09-11 05:21:23 PDT
Created attachment 211300 [details] Patch proposal Updated the patch against master, now we finally and actually removed any need of gail in the WebKitGTK+ codebase.
Gustavo Noronha (kov)
Comment 6 2013-09-11 06:08:31 PDT
Comment on attachment 211300 [details] Patch proposal \o/
Mario Sanchez Prada
Comment 7 2013-09-11 08:49:45 PDT
Comment on attachment 211300 [details] Patch proposal Thanks for the review
WebKit Commit Bot
Comment 8 2013-09-11 08:53:09 PDT
Comment on attachment 211300 [details] Patch proposal Rejecting attachment 211300 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 211300, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/1787062
Mario Sanchez Prada
Comment 9 2013-09-11 09:24:25 PDT
Committed r155534: <http://trac.webkit.org/changeset/155534>
Note You need to log in before you can comment on or make changes to this bug.