Bug 119651

Summary: [GObject] Wrap KeyboardEvent
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: New BugsAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, kangil.han, kondapallykalyan, mrobinson, xan.lopez, zan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch cdumez: review+

Gustavo Noronha (kov)
Reported 2013-08-09 20:28:51 PDT
[GObject] Wrap KeyboardEvent
Attachments
Patch (4.98 KB, patch)
2013-08-09 20:32 PDT, Gustavo Noronha (kov) 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2013-08-09 20:32:38 PDT
Created attachment 208471 [details] Patch
Gustavo Noronha (kov)
Comment 2 2013-08-09 20:34:12 PDT
This is required for this to work: https://bugzilla.gnome.org/show_bug.cgi?id=675060 (A UI to show users which have passwords saved for a site in Epiphany)
Chris Dumez
Comment 3 2013-08-09 22:47:40 PDT
Comment on attachment 208471 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208471&action=review > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:114 > + return "Event" if $parent eq "UIEvent" or $parent eq "MouseEvent" or $parent eq "KeyboardEvent"; Could we simply use $codeGenerator->InheritsInterface("Event") ? This does not look very scalable.
Gustavo Noronha (kov)
Comment 4 2013-08-10 08:44:17 PDT
Committed r153921: <http://trac.webkit.org/changeset/153921>
Note You need to log in before you can comment on or make changes to this bug.