Bug 119644

Summary: [iOS] isMainThread implementation with USE(WEB_THREAD)
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cmarcelo, commit-queue, dbates, ddkilzer, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix benjamin: review+

Joseph Pecoraro
Reported 2013-08-09 17:02:47 PDT
At the 2013 WebKit Contributors Meeting this year one of the discussions was upstreaming iOS WebKit: <https://docs.google.com/document/d/1jsqXPcwOkBo4L8taB_rmSY8oAZFCaGJ1CU20PI6p0kQ/edit?pli=1> Discussion: What do we do about ASSERT(isMainThread())? DECISION: Leave it named isMainThread()… On iOS isMainThread() means that the current thread is either the MainThread or WebThread and the current thread has the WebThreadLock.
Attachments
[PATCH] Proposed Fix (5.83 KB, patch)
2013-08-09 17:05 PDT, Joseph Pecoraro 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2013-08-09 17:05:21 PDT
Created attachment 208463 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2013-08-09 17:08:24 PDT
Attachment 208463 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/ios/WebCoreThread.cpp', u'Source/WTF/wtf/ios/WebCoreThread.h', u'Source/WTF/wtf/mac/MainThreadMac.mm']" exit_code: 1 Source/WTF/wtf/ios/WebCoreThread.h:28: #ifndef header guard has wrong style, please use: WTF_WebCoreThread_h [build/header_guard] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 3 2013-08-12 10:47:02 PDT
Committed <http://trac.webkit.org/changeset/153950>.
Note You need to log in before you can comment on or make changes to this bug.