Bug 119631 – [webkitpy] perf profiler attaches to WKTR after the WebProcess was launched

• Component: New Bugs
• Status: RESOLVED FIXED

[Zan Dobersek]

[webkitpy] perf profiler attaches to WKTR after the WebProcess was launched

[Zan Dobersek]

Created attachment 208437 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 208437 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208437&action=review

> Tools/Scripts/webkitpy/common/system/profiler.py:-162
> -        if perf_exitcode is None:  # This should always be the case, unless perf error'd out early.
> -            self._host.executive.interrupt(self._perf_process.pid)
> -
> -        perf_exitcode = self._perf_process.wait()
> -        if perf_exitcode not in (0, -2):  # The exit code should always be -2, as we're always interrupting perf.
> -            print "'perf record' failed (exit code: %i), can't process results:" % perf_exitcode
> -            return

Who is catching the error now?

> Tools/Scripts/webkitpy/port/driver.py:218
> +        if self._port.get_option('wrapper'):

Why don't we store this on a temporary variable?

[Zan Dobersek]

Created attachment 211188 [details]
Patch

[Zan Dobersek]

Thanks!

[Zan Dobersek]

Comment on attachment 211188 [details]
Patch

Clearing flags on attachment: 211188

Committed r155803: <http://trac.webkit.org/changeset/155803>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.