Bug 11963

Summary: Fix JS wrappers for SVG Lists operating on POD types
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Initial patch
none
Updated patch oliver: review+

Nikolas Zimmermann
Reported 2006-12-24 17:55:53 PST
Currently, the JS wrapping for SVG Lists works, but not "readwrite". Writing mySVGPointList.getItem(0).x = 10; didn't take any effect. The JS wrappers are functional, though the changes end up in nirvana. Attaching patch soon to fix it. This makes the carto.net SVG examples work much better, the text positioning from JS works now! (there is another bug report for it, which can be closed too, then)
Attachments
Initial patch (67.62 KB, patch)
2006-12-24 18:00 PST, Nikolas Zimmermann 		no flags
DetailsFormatted DiffDiff
Updated patch (67.82 KB, patch)
2006-12-24 18:07 PST, Nikolas Zimmermann 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2006-12-24 18:00:12 PST
Created attachment 12013 [details] Initial patch The attached patch, also fixes bug 11123: http://bugs.webkit.org/show_bug.cgi?id=11123
Nikolas Zimmermann
Comment 2 2006-12-24 18:07:16 PST
Created attachment 12014 [details] Updated patch Missing bug references in the ChangeLogs, fixed. Noticed by ddkilzer.
Oliver Hunt
Comment 3 2006-12-25 16:53:37 PST
Comment on attachment 12014 [details] Updated patch r=me, with the formatting only patch pulled out, as discussed in irc
Nikolas Zimmermann
Comment 4 2006-12-25 16:54:13 PST
Landed in r18415.
Note You need to log in before you can comment on or make changes to this bug.