Bug 11963 - Fix JS wrappers for SVG Lists operating on POD types
Summary: Fix JS wrappers for SVG Lists operating on POD types
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
Depends on:
Reported: 2006-12-24 17:55 PST by Nikolas Zimmermann
Modified: 2006-12-25 16:54 PST (History)
0 users

See Also:

Initial patch (67.62 KB, patch)
2006-12-24 18:00 PST, Nikolas Zimmermann
no flags Details | Formatted Diff | Diff
Updated patch (67.82 KB, patch)
2006-12-24 18:07 PST, Nikolas Zimmermann
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2006-12-24 17:55:53 PST
Currently, the JS wrapping for SVG Lists works, but not "readwrite". Writing
mySVGPointList.getItem(0).x = 10; didn't take any effect. The JS wrappers are
functional, though the changes end up in nirvana. Attaching patch soon to fix it.

This makes the carto.net SVG examples work much better, the text positioning
from JS works now! (there is another bug report for it, which can be closed too, then)
Comment 1 Nikolas Zimmermann 2006-12-24 18:00:12 PST
Created attachment 12013 [details]
Initial patch

The attached patch, also fixes bug 11123:
Comment 2 Nikolas Zimmermann 2006-12-24 18:07:16 PST
Created attachment 12014 [details]
Updated patch

Missing bug references in the ChangeLogs, fixed. Noticed by ddkilzer.
Comment 3 Oliver Hunt 2006-12-25 16:53:37 PST
Comment on attachment 12014 [details]
Updated patch

r=me, with the formatting only patch pulled out, as discussed in irc
Comment 4 Nikolas Zimmermann 2006-12-25 16:54:13 PST
Landed in r18415.