Bug 119613

Summary: move-by-word-visually-multi-space.html takes 21s and spends most of its time doing spelling and grammar checking
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: HTML EditingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enrica, rniwa, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Sample none

Simon Fraser (smfr)
Reported 2013-08-08 20:50:29 PDT
move-by-word-visually-multi-space.html is a very slow test: 21s on the bots. Sampling shows that it spends most of its time doing spell checking.
Attachments
Patch (5.50 KB, patch)
2013-08-08 21:19 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Sample (2.54 MB, text/plain)
2013-08-08 21:21 PDT, Simon Fraser (smfr) 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-08-08 20:52:47 PDT
Doing internals.setContinuousSpellCheckingEnabled(false); takes the runtime down from 14s to 4s on my machine.
Ryosuke Niwa
Comment 2 2013-08-08 20:58:37 PDT
(In reply to comment #0) > move-by-word-visually-multi-space.html is a very slow test: 21s on the bots. > > Sampling shows that it spends most of its time doing spell checking. That's really bad because we should never be spellchecking content that wasn't entered by the user. Do you have any traces for this test?
Simon Fraser (smfr)
Comment 3 2013-08-08 21:19:46 PDT
Created attachment 208394 [details] Patch
Simon Fraser (smfr)
Comment 4 2013-08-08 21:21:46 PDT
Created attachment 208395 [details] Sample
WebKit Commit Bot
Comment 5 2013-08-09 09:52:26 PDT
Comment on attachment 208394 [details] Patch Clearing flags on attachment: 208394 Committed r153897: <http://trac.webkit.org/changeset/153897>
WebKit Commit Bot
Comment 6 2013-08-09 09:52:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.