Bug 119601

Summary: Win64 missing ctiVMThrowTrampolineSlowpath
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Alex Christensen
Reported 2013-08-08 15:27:04 PDT
ctiVMThrowTrampolineSlowpath is not defined for the Win64 build of JavaScriptCore. Michael's fix is based on assembly from JITStubsX86_64.h that should be in JITStubsMSVC64.asm.
Attachments
Patch (1.38 KB, patch)
2013-08-08 15:29 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.68 KB, patch)
2013-08-14 13:00 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (3.53 KB, patch)
2013-08-14 13:28 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-08-08 15:29:28 PDT
Created attachment 208375 [details] Patch
Alex Christensen
Comment 2 2013-08-08 16:01:45 PDT
Comment on attachment 208375 [details] Patch Something is wrong with the calling convention. Something needs to be put on the stack, and I'm not even going to pretend to know exactly how to fix it. I'm going to leave this one to you, Michael.
Alex Christensen
Comment 3 2013-08-14 13:00:08 PDT
Created attachment 208753 [details] Patch
Michael Saboff
Comment 4 2013-08-14 13:26:43 PDT
Comment on attachment 208753 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208753&action=review > Source/JavaScriptCore/jit/JITStubsMSVC64.asm:86 > + mov rdi, r13 > + call cti_vm_throw_slowpath > + ; When cti_vm_throw_slowpath returns, rax has callFrame and rdx has handler address > + jmp rdx Remove this dead code.
Alex Christensen
Comment 5 2013-08-14 13:28:33 PDT
Created attachment 208754 [details] Patch
WebKit Commit Bot
Comment 6 2013-08-14 14:48:39 PDT
Comment on attachment 208754 [details] Patch Clearing flags on attachment: 208754 Committed r154075: <http://trac.webkit.org/changeset/154075>
WebKit Commit Bot
Comment 7 2013-08-14 14:48:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.