Summary: | [EFL][WK1] URL printing code in DumpRenderTree doesn't match WTR or Mac DRT | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | Tools / Tests | Assignee: | Ryuan Choi <ryuan.choi> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, commit-queue, gyuyoung.kim, gyuyoung.kim, rakuco, ryuan.choi | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2013-08-08 11:30:40 PDT
Adding Ryuan and Gyuyoung in CC since I believe they are maintaining EFL WK1. ap, will you submit a patch for this bug ? Otherwise, do you want we make a patch for this bug ? (In reply to comment #2) > ap, will you submit a patch for this bug ? Otherwise, do you want we make a patch for this bug ? I really think it is up to us to fix EFL bugs. (In reply to comment #3) > (In reply to comment #2) > > ap, will you submit a patch for this bug ? Otherwise, do you want we make a patch for this bug ? > > I really think it is up to us to fix EFL bugs. Looks like that as well. Ryuan or I will fix this soon. ;) Thank you! It would be much better for someone with a EFL build to do this, as there is likely to be quite a bit of test expectation cleanup. WebKitTestRunner code can probably serve as a model here. Created attachment 208583 [details]
Patch
(In reply to comment #5) > Thank you! It would be much better for someone with a EFL build to do this, as there is likely to be quite a bit of test expectation cleanup. > > WebKitTestRunner code can probably serve as a model here. WebKitTestRunner was good reference. I made patch similarly. Comment on attachment 208583 [details] Patch This patch lets the EFL port follow r153852. LGTM. However, ap might want to have final look before landing. Comment on attachment 208583 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208583&action=review Looks good to me too. > Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp:226 > +const WebCore::KURL DumpRenderTreeSupportEfl::provisionalUrl(const Evas_Object* ewkFrame) WebKit style would be "provisionalURL". I do not know if this code is intended to follow common WebKit style. > Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:350 > + KURL mainFrameUrl = KURL(ParsedURLString, ewk_frame_uri_get(browser->mainFrame())); Ditto. Created attachment 208593 [details]
StyleFixed
Comment on attachment 208593 [details] StyleFixed Clearing flags on attachment: 208593 Committed r153977: <http://trac.webkit.org/changeset/153977> All reviewed patches have been landed. Closing bug. |