Bug 119558

Summary:

Clean up: Simplifying the printing of the command line arguments passed to jsDriver.pl

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Tools / Tests

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, mrobinson

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mrobinson: review+

Daniel Bates

Reported 2013-08-07 14:51:49 PDT

Currently in Tools/Scripts/run-javascriptcore-tests we construct the command line to run jsDriver.pl twice: once to pretty print it standard output, and once to actually execute it. Moreover, what we print to standard output isn't equivalent to the command line we run jsDriver.pl as we exclude the prefix of /Tools/jhbuild/jhbuild-wrapper that is added for the GTK and EFL ports. We should construct the command line to execute jsDriver.pl once and then print it to standard output.

Attachments
Patch (2.05 KB, patch) 2013-08-07 14:56 PDT, Daniel Bates	mrobinson: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2013-08-07 14:56:57 PDT

Created attachment 208300 [details] Patch

Daniel Bates

Comment 2 2013-08-07 14:59:33 PDT

Committed r153804: <http://trac.webkit.org/changeset/153804>

Note You need to log in before you can comment on or make changes to this bug.