Bug 119535

Summary:

Fall out of simple image layer optimization if the image has EXIF rotation

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

Images

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, esprehn+autocc, glenn, kondapallykalyan, noam, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none
patch	simon.fraser: review+

Description Tim Horton 2013-08-06 19:09:06 PDT

We need to transform the image when painting it, so we need to fall out of the optimization. We could do some complicated things to keep the optimization in this case, but it's not a super critical case and the simple image layer optimization is relatively new.

<rdar://problem/14071174>

Comment 1 Tim Horton 2013-08-06 19:09:57 PDT

Conveniently the layer is already the right size/shape, so we really just need to tell RenderLayerBacking to do the right thing.

Comment 2 Tim Horton 2013-08-06 19:21:04 PDT

Created attachment 208231 [details]
patch

Comment 3 Tim Horton 2013-08-06 19:33:56 PDT

Created attachment 208233 [details]
patch

Comment 4 Tim Horton 2013-08-07 12:52:00 PDT

http://trac.webkit.org/changeset/153797

Comment 5 Benjamin Poulain 2013-08-11 22:04:10 PDT

Wouldn't a ref-test be nicer here?

Comment 6 Tim Horton 2013-08-11 22:15:39 PDT

(In reply to comment #5)
> Wouldn't a ref-test be nicer here?

Yes; I just borrowed the existing image-orientation test and made it composited, though.