Bug 119533

Summary: Hashing SecurityOrigin's can lead to trouble if you mutate them :(
Product: WebKit Reporter: Sam Weinig <sam>
Component: WebCore Misc.Assignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, buildbot, dimitris.apostolou, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch kling: review+

Sam Weinig
Reported 2013-08-06 17:55:01 PDT
Hashing SecurityOrigin's can lead to trouble if you mutate them :(
Attachments
Patch (2.19 KB, patch)
2013-08-06 18:06 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (2.82 KB, patch)
2013-08-06 19:24 PDT, Sam Weinig 		kling: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2013-08-06 18:06:18 PDT
Created attachment 208230 [details] Patch
Build Bot
Comment 2 2013-08-06 18:34:28 PDT
Comment on attachment 208230 [details] Patch Attachment 208230 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1418039
Build Bot
Comment 3 2013-08-06 18:49:44 PDT
Comment on attachment 208230 [details] Patch Attachment 208230 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1417041
Sam Weinig
Comment 4 2013-08-06 19:24:47 PDT
Created attachment 208232 [details] Patch
Andreas Kling
Comment 5 2013-08-07 06:05:43 PDT
Comment on attachment 208232 [details] Patch r=me Very related: bug 99266.
Alexey Proskuryakov
Comment 6 2013-08-07 11:40:32 PDT
Could you please also address comments around equal() in SecurityOrigin.h, and add a Radar link?
Sam Weinig
Comment 7 2013-08-08 14:59:58 PDT
Committed r153850: <http://trac.webkit.org/changeset/153850>
Sam Weinig
Comment 8 2013-08-08 15:00:39 PDT
*** Bug 99266 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.