Bug 119527

Summary: Web Inspector: Remove stale code in ResourceContentView
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2013-08-06 13:44:51 PDT
The ResourceContentView type changing handling was moved to ResourceClusterContentView a while ago. In the process some code was leftover in ResourceContentView which can be removed: this._resource.removeEventListener(WebInspector.Resource.Event.TypeDidChange, this._resourceTypeDidChange, this); ResourceContentView no longer adds that event listener to the resource, and doesn't have a this._resourceTypeDidChange function, so it is likely passing null and not removing anything.
Attachments
[PATCH] Proposed Fix (1.49 KB, patch)
2013-08-06 13:46 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-08-06 13:45:21 PDT
<rdar://problem/14664197>
Joseph Pecoraro
Comment 2 2013-08-06 13:46:44 PDT
Created attachment 208215 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2013-08-06 14:37:17 PDT
Comment on attachment 208215 [details] [PATCH] Proposed Fix Clearing flags on attachment: 208215 Committed r153765: <http://trac.webkit.org/changeset/153765>
WebKit Commit Bot
Comment 4 2013-08-06 14:37:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.