Bug 119510

Summary:

Update scheme list according to latest specification

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

New Bugs

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, eflews.bot, gyuyoung.kim, kling, rakuco, rniwa, syoichi

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Patch	none
Patch	none

Gyuyoung Kim

Reported 2013-08-05 21:14:08 PDT

New schemes are added to it additionally. Those are im, ircs and webtai. As additional work, scheme order is listed to be sync with spec. Spec: http://www.w3.org/html/wg/drafts/html/master/webappapis.html#custom-handlers Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=155491

Attachments
Patch (10.64 KB, patch) 2013-08-05 22:53 PDT, EFL EWS Bot	no flags	Details Formatted Diff Diff
Patch (10.64 KB, patch) 2013-08-05 22:55 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (10.64 KB, patch) 2013-08-05 23:10 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (10.62 KB, patch) 2013-08-05 23:18 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (543.73 KB, application/zip) 2013-08-08 00:43 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (492.34 KB, application/zip) 2013-08-08 01:14 PDT, Build Bot	no flags	Details
Patch (10.57 KB, patch) 2013-08-08 05:56 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (10.48 KB, patch) 2013-08-12 18:29 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

EFL EWS Bot

Comment 1 2013-08-05 22:53:28 PDT

Created attachment 208165 [details] Patch

Gyuyoung Kim

Comment 2 2013-08-05 22:55:53 PDT

Created attachment 208166 [details] Patch

Gyuyoung Kim

Comment 3 2013-08-05 23:10:09 PDT

Created attachment 208167 [details] Patch

Gyuyoung Kim

Comment 4 2013-08-05 23:18:29 PDT

Created attachment 208168 [details] Patch

Gyuyoung Kim

Comment 5 2013-08-07 23:10:46 PDT

CC'ing Kling. Could you take a look this patch ?

Build Bot

Comment 6 2013-08-08 00:43:24 PDT

Comment on attachment 208168 [details] Patch Attachment 208168 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1431080 New failing tests: fast/dom/unregister-protocol-handler.html

Build Bot

Comment 7 2013-08-08 00:43:28 PDT

Created attachment 208317 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4

Build Bot

Comment 8 2013-08-08 01:14:27 PDT

Comment on attachment 208168 [details] Patch Attachment 208168 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1430079 New failing tests: fast/dom/unregister-protocol-handler.html

Build Bot

Comment 9 2013-08-08 01:14:32 PDT

Created attachment 208318 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.4

Gyuyoung Kim

Comment 10 2013-08-08 05:56:09 PDT

Created attachment 208332 [details] Patch

Chris Dumez

Comment 11 2013-08-12 10:51:38 PDT

Comment on attachment 208332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208332&action=review > Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:65 > + "webtai", http://www.whatwg.org/specs/web-apps/current-work/#whitelisted-scheme says "wtai" not "webtai"

Gyuyoung Kim

Comment 12 2013-08-12 18:29:57 PDT

Created attachment 208581 [details] Patch

Gyuyoung Kim

Comment 13 2013-08-12 18:30:48 PDT

(In reply to comment #11) > (From update of attachment 208332 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208332&action=review > > > Source/WebCore/Modules/navigatorcontentutils/NavigatorContentUtils.cpp:65 > > + "webtai", > > http://www.whatwg.org/specs/web-apps/current-work/#whitelisted-scheme says "wtai" not "webtai" Nice catch! it looks spec is being changed. Patch is updated according to latest spec.

Chris Dumez

Comment 14 2013-08-12 22:48:26 PDT

Comment on attachment 208581 [details] Patch Looks fine. r=me.

WebKit Commit Bot

Comment 15 2013-08-13 00:10:28 PDT

Comment on attachment 208581 [details] Patch Clearing flags on attachment: 208581 Committed r153986: <http://trac.webkit.org/changeset/153986>

WebKit Commit Bot

Comment 16 2013-08-13 00:10:35 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.