Bug 119505

Summary: Delay Arguments creation in strict mode
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: eflews.bot, gyuyoung.kim
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Oliver Hunt
Reported 2013-08-05 18:05:39 PDT
Delay Arguments creation in strict mode
Attachments
Patch (9.71 KB, patch)
2013-08-05 18:10 PDT, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (12.61 KB, patch)
2013-08-06 12:04 PDT, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2013-08-05 18:10:53 PDT
Created attachment 208162 [details] Patch
Geoffrey Garen
Comment 2 2013-08-05 18:15:51 PDT
Comment on attachment 208162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208162&action=review > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1749 > - if (m_codeBlock->usesArguments() && m_codeBlock->numParameters() != 1 && !m_codeBlock->isStrictMode()) { > + if (m_codeBlock->usesArguments() && m_codeBlock->numParameters() != 1 && !isStrictMode()) { Doesn't this need to be !shouldTearOffArgumentsEagerly()?
Oliver Hunt
Comment 3 2013-08-05 18:17:02 PDT
(In reply to comment #2) > (From update of attachment 208162 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208162&action=review > > > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:1749 > > - if (m_codeBlock->usesArguments() && m_codeBlock->numParameters() != 1 && !m_codeBlock->isStrictMode()) { > > + if (m_codeBlock->usesArguments() && m_codeBlock->numParameters() != 1 && !isStrictMode()) { > > Doesn't this need to be !shouldTearOffArgumentsEagerly()? Nope, we perform the Arguments object tear off during arguments object creation when we're in strict mode.
EFL EWS Bot
Comment 4 2013-08-05 18:55:34 PDT
Comment on attachment 208162 [details] Patch Attachment 208162 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1350033
Oliver Hunt
Comment 5 2013-08-06 12:04:30 PDT
Created attachment 208209 [details] Patch
Geoffrey Garen
Comment 6 2013-08-06 14:10:29 PDT
Comment on attachment 208209 [details] Patch r=me
Oliver Hunt
Comment 7 2013-08-06 14:19:02 PDT
Committed r153763: <http://trac.webkit.org/changeset/153763>
Geoffrey Garen
Comment 8 2013-08-20 16:40:43 PDT
<rdar://problem/14790809>
Note You need to log in before you can comment on or make changes to this bug.