Summary: | Move TypedArray implementation into JSC | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Oliver Hunt <oliver> | ||||||||||||||||
Component: | New Bugs | Assignee: | Oliver Hunt <oliver> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | cdumez, eflews.bot, gyuyoung.kim, webkit-ews, xinchao.peng | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Bug Depends on: | |||||||||||||||||||
Bug Blocks: | 119064 | ||||||||||||||||||
Attachments: |
|
Description
Oliver Hunt
2013-08-05 10:28:32 PDT
Created attachment 208135 [details]
Patch
Comment on attachment 208135 [details] Patch Attachment 208135 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1386130 Comment on attachment 208135 [details] Patch Attachment 208135 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1374176 Comment on attachment 208135 [details] Patch Attachment 208135 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1375168 Comment on attachment 208135 [details] Patch Attachment 208135 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1383190 Created attachment 208138 [details]
Patch
Comment on attachment 208138 [details]
Patch
Thanks bro!
waiting for so many builds :-( Comment on attachment 208138 [details] Patch Attachment 208138 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1362038 Comment on attachment 208138 [details] Patch Attachment 208138 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1343033 Comment on attachment 208138 [details] Patch Attachment 208138 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1328039 Created attachment 208141 [details]
Patch
Comment on attachment 208141 [details] Patch Attachment 208141 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1363042 Comment on attachment 208141 [details] Patch Attachment 208141 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1364051 Comment on attachment 208141 [details] Patch Attachment 208141 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1327053 Created attachment 208142 [details]
Patch
Created attachment 208144 [details]
Patch
sigh, lost project file changes going from one machine to the other, let's try this again Comment on attachment 208144 [details] Patch Attachment 208144 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1366074 Created attachment 208148 [details]
Patch
Comment on attachment 208148 [details] Patch Attachment 208148 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1346072 Created attachment 208151 [details]
Patch
Committed r153728: <http://trac.webkit.org/changeset/153728> (In reply to comment #0) > Move TypedArray implementation into JSC I have a quession : Why do you do this? What is its advantage ? (In reply to comment #24) > (In reply to comment #0) > > Move TypedArray implementation into JSC > > I have a quession : > Why do you do this? What is its advantage ? It was explained on the mailing list. Please check: [webkit-dev] Heads up: large typed array rewrite GNUmake build failed : log info : ./.libs/../DerivedSources/WebCore/.libs/libWebCoreInternals_la-JSInternals.o: In function `_ZN7WebCore43jsInternalsPrototypeFunctionSerializeObjectEPN3JSC9ExecStateE': JSInternals.cpp:(.text+0x7f78): undefined reference to `_ZN7WebCore21SerializedScriptValue6createEPN3JSC9ExecStateENS1_7JSValueEPN3WTF6VectorINS5_6RefPtrINS_11MessagePortEEELj1ENS5_15CrashOnOverflowEEEPNS6_INS7_INS1_11ArrayBufferEEELj1ESA_EENS_22SerializationErrorModeE' JSInternals.cpp:(.text+0x8028): undefined reference to `_ZN7WebCore4toJSEPN3JSC9ExecStateEPNS_17JSDOMGlobalObjectEPNS0_11ArrayBufferE' collect2: error: ld returned 1 exit status |