Bug 119469

Summary: Loading a video with a custom URL scheme will result in stalling playback
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, glenn
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch eric.carlson: review+

Jer Noble
Reported 2013-08-03 12:30:02 PDT
Loading a video with a custom URL scheme will result in stalling playback
Attachments
Patch (7.66 KB, patch)
2013-08-03 12:34 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2013-08-03 12:30:18 PDT
<rdar://problem/14637544>
Jer Noble
Comment 2 2013-08-03 12:34:51 PDT
Created attachment 208070 [details] Patch
Eric Carlson
Comment 3 2013-08-04 17:53:48 PDT
Comment on attachment 208070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208070&action=review > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:961 > +void MediaPlayerPrivateAVFoundationObjC::didStopLoadingRequest(AVAssetResourceLoadingRequest* avRequest) Nit: AVAssetResourceLoadingRequest is an ObjC type so the "*" should be next to the variable. > Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:49 > + static PassRefPtr<WebCoreAVFResourceLoader> create(MediaPlayerPrivateAVFoundationObjC* parent, AVAssetResourceLoadingRequest*); Super nit-pick: there should be a space between "AVAssetResourceLoadingRequest" and "*" . > Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:46 > +PassRefPtr<WebCoreAVFResourceLoader> WebCoreAVFResourceLoader::create(MediaPlayerPrivateAVFoundationObjC* parent, AVAssetResourceLoadingRequest* avRequest) Ditto. > Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:53 > WebCoreAVFResourceLoader::WebCoreAVFResourceLoader(MediaPlayerPrivateAVFoundationObjC* parent, AVAssetResourceLoadingRequest* avRequest) Ditto.
Jer Noble
Comment 4 2013-08-05 08:29:04 PDT
Committed r153706: <http://trac.webkit.org/changeset/153706>
Note You need to log in before you can comment on or make changes to this bug.