Bug 119469 - Loading a video with a custom URL scheme will result in stalling playback
Summary: Loading a video with a custom URL scheme will result in stalling playback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-03 12:30 PDT by Jer Noble
Modified: 2013-08-05 08:29 PDT (History)
3 users (show)

See Also:

Attachments
Patch (7.66 KB, patch)
2013-08-03 12:34 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2013-08-03 12:30:02 PDT 
Loading a video with a custom URL scheme will result in stalling playback
Comment 1 Jer Noble 2013-08-03 12:30:18 PDT 
<rdar://problem/14637544>
Comment 2 Jer Noble 2013-08-03 12:34:51 PDT 
Created attachment 208070 [details]
Patch
Comment 3 Eric Carlson 2013-08-04 17:53:48 PDT 
Comment on attachment 208070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208070&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:961
> +void MediaPlayerPrivateAVFoundationObjC::didStopLoadingRequest(AVAssetResourceLoadingRequest* avRequest)

Nit: AVAssetResourceLoadingRequest is an ObjC type so the "*" should be next to the variable.

> Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:49
> +    static PassRefPtr<WebCoreAVFResourceLoader> create(MediaPlayerPrivateAVFoundationObjC* parent, AVAssetResourceLoadingRequest*);

Super nit-pick: there should be a space between "AVAssetResourceLoadingRequest" and "*" .

> Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:46
> +PassRefPtr<WebCoreAVFResourceLoader> WebCoreAVFResourceLoader::create(MediaPlayerPrivateAVFoundationObjC* parent, AVAssetResourceLoadingRequest* avRequest)

Ditto.

> Source/WebCore/platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:53
>  WebCoreAVFResourceLoader::WebCoreAVFResourceLoader(MediaPlayerPrivateAVFoundationObjC* parent, AVAssetResourceLoadingRequest* avRequest)

Ditto.
Comment 4 Jer Noble 2013-08-05 08:29:04 PDT 
Committed r153706: <http://trac.webkit.org/changeset/153706>