Bug 119460

Summary: Remove no-arguments constructor to PropertySlot
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fix ggaren: review+

Gavin Barraclough
Reported 2013-08-02 14:07:42 PDT
This is unsafe if getValue is subsequently called, and the property is a getter. Simplest to just remove it.
Attachments
fix (30.64 KB, patch)
2013-08-02 14:09 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2013-08-02 14:09:43 PDT
Created attachment 208045 [details] fix
Geoffrey Garen
Comment 2 2013-08-02 14:12:51 PDT
Comment on attachment 208045 [details] fix r=me
Gavin Barraclough
Comment 3 2013-08-02 15:31:20 PDT
Fixed in r153673
Benjamin Poulain
Comment 4 2013-08-02 16:42:15 PDT
Most ports are failing to build after this change.
Note You need to log in before you can comment on or make changes to this bug.