Bug 119457

Summary: The LayoutMilestones didLayout callback should only fire for the main frame
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Layout and RenderingAssignee: Beth Dakin <bdakin>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, esprehn+autocc, japhet, kangil.han, sam, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
webkit-ews: commit-queue-
Patch sam: review+

Beth Dakin
Reported 2013-08-02 13:39:00 PDT
The LayoutMilestones didLayout callback should only fire for the main frame since it is a WebView/WebCore::Page-level concept.
Attachments
Patch (3.39 KB, patch)
2013-08-02 13:42 PDT, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch (13.33 KB, patch)
2013-08-06 16:42 PDT, Beth Dakin 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (13.35 KB, patch)
2013-08-06 17:00 PDT, Beth Dakin 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2013-08-02 13:42:06 PDT
Created attachment 208042 [details] Patch
Beth Dakin
Comment 2 2013-08-02 14:51:32 PDT
Comment on attachment 208042 [details] Patch Sam and I talked about this, and we want to take a slightly different approach here.
Beth Dakin
Comment 3 2013-08-06 16:42:28 PDT
Created attachment 208225 [details] Patch
Early Warning System Bot
Comment 4 2013-08-06 16:54:55 PDT
Comment on attachment 208225 [details] Patch Attachment 208225 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1418015
Early Warning System Bot
Comment 5 2013-08-06 16:58:20 PDT
Comment on attachment 208225 [details] Patch Attachment 208225 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1414060
Beth Dakin
Comment 6 2013-08-06 17:00:12 PDT
Created attachment 208228 [details] Patch
Sam Weinig
Comment 7 2013-08-12 14:19:20 PDT
Comment on attachment 208228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208228&action=review > Source/WebCore/loader/FrameLoader.cpp:2286 > +#ifndef NDEBUG You should use !ASSERT_DISABLED here instead.
Beth Dakin
Comment 8 2013-08-12 14:37:44 PDT
Thanks Sam! http://trac.webkit.org/changeset/153958
Note You need to log in before you can comment on or make changes to this bug.