Bug 119455

Summary: [Forms: color] The positioning of the popover color well is inverted
Product: WebKit Reporter: Ruth Fong <ruthiecftg>
Component: FormsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, beidson, commit-queue, dino, jonlee, ruthiecftg, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Ruth Fong
Reported 2013-08-02 13:00:58 PDT
The IntRect object passed to WebColorPickerMac assumes that the origin is at the top-left of the screen, while by default NSRect assumes that the origin is at bottom-left of the screen. The needed change will be in WKColorPopoverMac::initWithFrame: inView:.
Attachments
Patch (1.45 KB, patch)
2013-08-02 13:25 PDT, Ruth Fong 		no flags
DetailsFormatted DiffDiff
Patch (1.44 KB, patch)
2013-08-02 13:31 PDT, Ruth Fong 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-08-02 13:02:07 PDT
<rdar://problem/14635621>
Ruth Fong
Comment 2 2013-08-02 13:25:54 PDT
Created attachment 208039 [details] Patch
Tim Horton
Comment 3 2013-08-02 13:27:56 PDT
Comment on attachment 208039 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208039&action=review > Source/WebKit2/ChangeLog:12 > + (-[WKColorPopoverMac initWithFrame:WebCore::inView:]): Looks like the change log thing did something crazy here. Please take the random WebCore namespace out.
Ruth Fong
Comment 4 2013-08-02 13:31:32 PDT
Created attachment 208040 [details] Patch
WebKit Commit Bot
Comment 5 2013-08-02 13:34:23 PDT
Comment on attachment 208040 [details] Patch Rejecting attachment 208040 [details] from review queue. ruthiecftg@gmail.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.
WebKit Commit Bot
Comment 6 2013-08-02 14:26:15 PDT
Comment on attachment 208040 [details] Patch Clearing flags on attachment: 208040 Committed r153667: <http://trac.webkit.org/changeset/153667>
WebKit Commit Bot
Comment 7 2013-08-02 14:26:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.