Bug 119455 – [Forms: color] The positioning of the popover color well is inverted

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Ruth Fong]

The IntRect object passed to WebColorPickerMac assumes that the origin is at the top-left of the screen, while by default NSRect assumes that the origin is at bottom-left of the screen.

The needed change will be in WKColorPopoverMac::initWithFrame: inView:.

[Radar WebKit Bug Importer]

<rdar://problem/14635621>

[Ruth Fong]

Created attachment 208039 [details]
Patch

[Tim Horton]

Comment on attachment 208039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208039&action=review

> Source/WebKit2/ChangeLog:12
> +        (-[WKColorPopoverMac initWithFrame:WebCore::inView:]):

Looks like the change log thing did something crazy here. Please take the random WebCore namespace out.

[Ruth Fong]

Created attachment 208040 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 208040 [details]
Patch

Rejecting attachment 208040 [details] from review queue.

[e-mail] does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.

[WebKit Commit Bot]

Comment on attachment 208040 [details]
Patch

Clearing flags on attachment: 208040

Committed r153667: <http://trac.webkit.org/changeset/153667>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.