Bug 119455 - [Forms: color] The positioning of the popover color well is inverted
Summary: [Forms: color] The positioning of the popover color well is inverted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-02 13:00 PDT by Ruth Fong
Modified: 2013-08-02 14:26 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.45 KB, patch)
2013-08-02 13:25 PDT, Ruth Fong 		no flags Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2013-08-02 13:31 PDT, Ruth Fong 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ruth Fong 2013-08-02 13:00:58 PDT 
The IntRect object passed to WebColorPickerMac assumes that the origin is at the top-left of the screen, while by default NSRect assumes that the origin is at bottom-left of the screen.

The needed change will be in WKColorPopoverMac::initWithFrame: inView:.
Comment 1 Radar WebKit Bug Importer 2013-08-02 13:02:07 PDT 
<rdar://problem/14635621>
Comment 2 Ruth Fong 2013-08-02 13:25:54 PDT 
Created attachment 208039 [details]
Patch
Comment 3 Tim Horton 2013-08-02 13:27:56 PDT 
Comment on attachment 208039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208039&action=review

> Source/WebKit2/ChangeLog:12
> +        (-[WKColorPopoverMac initWithFrame:WebCore::inView:]):

Looks like the change log thing did something crazy here. Please take the random WebCore namespace out.
Comment 4 Ruth Fong 2013-08-02 13:31:32 PDT 
Created attachment 208040 [details]
Patch
Comment 5 WebKit Commit Bot 2013-08-02 13:34:23 PDT 
Comment on attachment 208040 [details]
Patch

Rejecting attachment 208040 [details] from review queue.

ruthiecftg@gmail.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your reviewer rights.
Comment 6 WebKit Commit Bot 2013-08-02 14:26:15 PDT 
Comment on attachment 208040 [details]
Patch

Clearing flags on attachment: 208040

Committed r153667: <http://trac.webkit.org/changeset/153667>
Comment 7 WebKit Commit Bot 2013-08-02 14:26:17 PDT 
All reviewed patches have been landed.  Closing bug.