Summary: | [CSS Background Blending] Specifying background-image and background-color with opaque image doesn't trigger blending | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mihai Tica <mitica> | ||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, mihnea, rniwa, WebkitBugTracker | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 108546 | ||||||||||||
Attachments: |
|
Description
Mihai Tica
2013-08-02 00:51:19 PDT
Created attachment 207989 [details]
Patch
Comment on attachment 207989 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207989&action=review > LayoutTests/ChangeLog:12 > + * css3/compositing/background-blend-mode-separate-layer-declaration.html: Added. > + * platform/mac/css3/compositing/background-blend-mode-separate-layer-declaration-expected.png: Added. > + * platform/mac/css3/compositing/background-blend-mode-separate-layer-declaration-expected.txt: Added. Patch looks great! Can you please use an ref test instead of an pixel test? r- until you added a ref test. (In reply to comment #2) > (From update of attachment 207989 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207989&action=review > > > LayoutTests/ChangeLog:12 > > + * css3/compositing/background-blend-mode-separate-layer-declaration.html: Added. > > + * platform/mac/css3/compositing/background-blend-mode-separate-layer-declaration-expected.png: Added. > > + * platform/mac/css3/compositing/background-blend-mode-separate-layer-declaration-expected.txt: Added. > > Patch looks great! Can you please use an ref test instead of an pixel test? r- until you added a ref test. The bug isn't showing up when specifying background-image with an SVG. Instead, the problem seems to be related only to opaque images, so I'm guessing we can't add a ref test. Created attachment 208013 [details]
Patch
Adding reference test
Comment on attachment 208013 [details] Patch Attachment 208013 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1329181 New failing tests: media/track/text-track-cue-is-reachable.html Created attachment 208020 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Created attachment 208030 [details]
Patch
Comment on attachment 208030 [details]
Patch
r=me
Comment on attachment 208030 [details] Patch Clearing flags on attachment: 208030 Committed r153702: <http://trac.webkit.org/changeset/153702> All reviewed patches have been landed. Closing bug. |