Bug 119432

Summary: Remove redundant call of argsList->current() from loops in CSSParser
Product: WebKit Reporter: Byungwoo Lee <bw80.lee>
Component: CSSAssignee: Byungwoo Lee <bw80.lee>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Byungwoo Lee
Reported 2013-08-01 23:39:37 PDT
while loops in CSSParser call argList->current() function at the start of each iteration, but this is redundant because argsList->next() at the end of the iteration calls the argList->current() and returns the result.
Attachments
Patch (3.61 KB, patch)
2013-08-01 23:47 PDT, Byungwoo Lee 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Byungwoo Lee
Comment 1 2013-08-01 23:40:35 PDT
blink merge from : https://src.chromium.org/viewvc/blink?view=rev&revision=155402
Byungwoo Lee
Comment 2 2013-08-01 23:47:33 PDT
Created attachment 207986 [details] Patch
Chris Dumez
Comment 3 2013-08-02 00:01:57 PDT
Comment on attachment 207986 [details] Patch Ok, r=me.
WebKit Commit Bot
Comment 4 2013-08-02 03:47:50 PDT
Comment on attachment 207986 [details] Patch Clearing flags on attachment: 207986 Committed r153643: <http://trac.webkit.org/changeset/153643>
WebKit Commit Bot
Comment 5 2013-08-02 03:47:53 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.