Summary: | Quirksmode: Break Tag Extra Space Bug | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||||||||||
Component: | Layout and Rendering | Assignee: | Robert Hogan <robert> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, esprehn+autocc, glenn, kling, koivisto, kondapallykalyan, mitz, rniwa, robert, webkit | ||||||||||||
Priority: | P2 | Keywords: | HasReduction | ||||||||||||
Version: | 420+ | ||||||||||||||
Hardware: | Mac | ||||||||||||||
OS: | OS X 10.4 | ||||||||||||||
URL: | http://www.quirksmode.org/bugreports/archives/2006/10/Break_Tag_Extra_Space_Bug.html | ||||||||||||||
Bug Depends on: | |||||||||||||||
Bug Blocks: | 9610 | ||||||||||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2006-12-23 04:40:00 PST
Created attachment 11981 [details]
Test page
No change in behavior with (tested with WebKit nightly build r31893): <http://trac.webkit.org/projects/webkit/changeset/31734> Created attachment 207473 [details]
Patch
Comment on attachment 207473 [details] Patch Attachment 207473 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1243608 New failing tests: csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html editing/selection/leak-document-with-selection-inside.html csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html Created attachment 207592 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Comment on attachment 207473 [details]
Patch
r=me, but we know that what we really want to do is strip this trailing space out always. Let's file a follow-up bug to do just that and let's put FIXMEs in the code that indicate the right-alignment hack is temporary.
Created attachment 211927 [details]
Patch
Comment on attachment 211927 [details] Patch Rejecting attachment 211927 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 211927, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/1825105 Created attachment 211947 [details]
Patch
So much FIXME and commentary. Comment on attachment 211947 [details] Patch Clearing flags on attachment: 211947 Committed r156053: <http://trac.webkit.org/changeset/156053> All reviewed patches have been landed. Closing bug. |