| Summary: | hasIndexingHeader should be a property of the Structure, not just the IndexingType | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Filip Pizlo <fpizlo> | ||||
| Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | barraclough, eflews.bot, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 119064 | ||||||
| Attachments: |
|
||||||
|
Description
Filip Pizlo
2013-08-01 19:08:25 PDT
Created attachment 207974 [details]
the patch
Comment on attachment 207974 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=207974&action=review > Source/JavaScriptCore/runtime/Structure.h:233 > + return hasIndexedProperties(indexingType()); Perhaps hasIndexedProperties() should be moved into Structure as well for the sake of consistency? (In reply to comment #2) > (From update of attachment 207974 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207974&action=review > > > Source/JavaScriptCore/runtime/Structure.h:233 > > + return hasIndexedProperties(indexingType()); > > Perhaps hasIndexedProperties() should be moved into Structure as well for the sake of consistency? We sometimes call that one without having a Structure*, as you would sort of expect: the point is that the indexing type always entirely determines whether or not you have indexed properties, in the pure-JS-object sense (rather than the typed-array or string sense). Comment on attachment 207974 [details] the patch Attachment 207974 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1330019 Landed in http://trac.webkit.org/changeset/153657 |