Bug 119422

Summary: hasIndexingHeader should be a property of the Structure, not just the IndexingType
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, eflews.bot, ggaren, gyuyoung.kim, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 119064    
Attachments:
Description Flags
the patch oliver: review+, eflews.bot: commit-queue-

Filip Pizlo
Reported 2013-08-01 19:08:25 PDT
Patch forthcoming.
Attachments
the patch (11.25 KB, patch)
2013-08-01 19:14 PDT, Filip Pizlo 		oliver: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-08-01 19:14:31 PDT
Created attachment 207974 [details] the patch
Mark Hahnenberg
Comment 2 2013-08-01 19:17:01 PDT
Comment on attachment 207974 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=207974&action=review > Source/JavaScriptCore/runtime/Structure.h:233 > + return hasIndexedProperties(indexingType()); Perhaps hasIndexedProperties() should be moved into Structure as well for the sake of consistency?
Filip Pizlo
Comment 3 2013-08-01 19:18:32 PDT
(In reply to comment #2) > (From update of attachment 207974 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207974&action=review > > > Source/JavaScriptCore/runtime/Structure.h:233 > > + return hasIndexedProperties(indexingType()); > > Perhaps hasIndexedProperties() should be moved into Structure as well for the sake of consistency? We sometimes call that one without having a Structure*, as you would sort of expect: the point is that the indexing type always entirely determines whether or not you have indexed properties, in the pure-JS-object sense (rather than the typed-array or string sense).
EFL EWS Bot
Comment 4 2013-08-01 19:40:30 PDT
Comment on attachment 207974 [details] the patch Attachment 207974 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1330019
Filip Pizlo
Comment 5 2013-08-02 11:26:52 PDT
Landed in http://trac.webkit.org/changeset/153657
Note You need to log in before you can comment on or make changes to this bug.