Bug 119412

Summary: Lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Plug-insAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, mrowe, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Leaks
none
Patch
simon.fraser: review+
My patch none

Simon Fraser (smfr)
Reported 2013-08-01 15:04:48 PDT
I ran run-webkit-tests --debug --leaks -2 LayoutTests/compositing/ and got lots of leaks under WebContext::pluginInfoStoreDidLoadPlugins()
Attachments
Leaks (181.96 KB, text/plain)
2013-08-01 15:05 PDT, Simon Fraser (smfr) 		no flags
Details
Patch (2.42 KB, patch)
2013-08-01 15:17 PDT, Anders Carlsson 		simon.fraser: review+
DetailsFormatted DiffDiff
My patch (2.22 KB, patch)
2013-08-01 15:18 PDT, Mark Rowe (bdash) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-08-01 15:05:07 PDT
Created attachment 207958 [details] Leaks
Mark Rowe (bdash)
Comment 2 2013-08-01 15:15:57 PDT
Oh hey, I totally have a patch sitting in my tree that fixes this!
Anders Carlsson
Comment 3 2013-08-01 15:17:06 PDT
Created attachment 207961 [details] Patch
Mark Rowe (bdash)
Comment 4 2013-08-01 15:18:17 PDT
Created attachment 207962 [details] My patch This one fixes the bogus lifetime of the array we pass to the callback.
Mark Rowe (bdash)
Comment 5 2013-08-01 15:23:06 PDT
Anders pointed out that the callback in question has already shipped as part of a Safari release on OS X so we can't just retroactively change the ownership semantics without backwards-compatiblity concerns. We'd need to only change it for new clients, perhaps by bumping the version of the client callback structure.
Anders Carlsson
Comment 6 2013-08-01 15:26:12 PDT
Committed r153616: <http://trac.webkit.org/changeset/153616>
Note You need to log in before you can comment on or make changes to this bug.