Bug 119409

Summary:

DFG optimizations don't handle neutered arrays properly

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, barraclough, buildbot, commit-queue, eflews.bot, ggaren, gyuyoung.kim, jsbell, mark.lam, mhahnenberg, msaboff, oliver, rniwa, sam

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	mhahnenberg: review+, eflews.bot: commit-queue-
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none

Filip Pizlo

Reported 2013-08-01 13:55:54 PDT

Patch forthcoming. <rdar://problem/14615180>

Attachments
the patch (8.65 KB, patch) 2013-08-01 13:58 PDT, Filip Pizlo	mhahnenberg: review+ eflews.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (571.12 KB, application/zip) 2013-08-01 15:06 PDT, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Filip Pizlo

Comment 1 2013-08-01 13:58:19 PDT

Created attachment 207950 [details] the patch

Mark Hahnenberg

Comment 2 2013-08-01 14:04:12 PDT

Comment on attachment 207950 [details] the patch r=me

Oliver Hunt

Comment 3 2013-08-01 14:04:36 PDT

Comment on attachment 207950 [details] the patch r=me. Typed arrays are so terrible.

EFL EWS Bot

Comment 4 2013-08-01 14:14:43 PDT

Comment on attachment 207950 [details] the patch Attachment 207950 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1318136

Build Bot

Comment 5 2013-08-01 15:06:49 PDT

Comment on attachment 207950 [details] the patch Attachment 207950 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1309228 New failing tests: fast/js/dfg-typed-array-neuter.html fast/canvas/webgl/typed-arrays-in-workers.html webgl/conformance/typedarrays/typed-arrays-in-workers.html

Build Bot

Comment 6 2013-08-01 15:06:53 PDT

Created attachment 207959 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.4

Filip Pizlo

Comment 7 2013-08-01 15:13:29 PDT

Landed with some additional fixes in http://trac.webkit.org/changeset/153613

Note You need to log in before you can comment on or make changes to this bug.