Bug 119394

Summary:

Frame flattening: Change the logic on whether resize event needs to be dispatched.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Frames

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser, webkit-bug-importer, yongjun_zhang

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

zalan

Reported 2013-08-01 05:49:45 PDT

Remove the recently added m_resizeEventAllowed and simply go with frameFlatteningEnabled() check.

Attachments
Patch (10.84 KB, patch) 2013-08-01 06:03 PDT, zalan	no flags	Details Formatted Diff Diff
Patch for landing (8.30 KB, patch) 2013-08-02 01:02 PDT, zalan	no flags	Details Formatted Diff Diff
Patch for landing (10.82 KB, patch) 2013-08-02 01:08 PDT, zalan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

zalan

Comment 1 2013-08-01 06:03:05 PDT

Created attachment 207920 [details] Patch

Simon Fraser (smfr)

Comment 2 2013-08-01 08:46:39 PDT

Comment on attachment 207920 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207920&action=review > Source/WebCore/page/FrameView.h:539 > + bool supportsFrameFlattening() const; It's not clear what this means; does it apply only to this frame, or to this platform?

zalan

Comment 3 2013-08-01 08:49:54 PDT

(In reply to comment #2) > (From update of attachment 207920 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207920&action=review > > > Source/WebCore/page/FrameView.h:539 > > + bool supportsFrameFlattening() const; > > It's not clear what this means; does it apply only to this frame, or to this platform? Indeed. I'll fix that before landing. Thanks!

zalan

Comment 4 2013-08-02 01:02:56 PDT

Created attachment 207990 [details] Patch for landing

zalan

Comment 5 2013-08-02 01:04:11 PDT

Comment on attachment 207990 [details] Patch for landing missing testcase

zalan

Comment 6 2013-08-02 01:08:42 PDT

Created attachment 207991 [details] Patch for landing

WebKit Commit Bot

Comment 7 2013-08-02 01:57:12 PDT

Comment on attachment 207991 [details] Patch for landing Clearing flags on attachment: 207991 Committed r153640: <http://trac.webkit.org/changeset/153640>

WebKit Commit Bot

Comment 8 2013-08-02 01:57:16 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.