Bug 119379

Summary: Remove return statement in void function
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: WebKit2Assignee: Kwang Yul Seo <skyul>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Kwang Yul Seo
Reported 2013-07-31 23:57:37 PDT
It does not make sense to return a value in void function.
Attachments
Patch (1.77 KB, patch)
2013-08-01 00:38 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Patch (1.82 KB, patch)
2013-08-01 00:45 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2013-08-01 00:38:36 PDT
Created attachment 207902 [details] Patch
WebKit Commit Bot
Comment 2 2013-08-01 00:40:51 PDT
Attachment 207902 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1 Source/WebKit2/WebProcess/WebProcess.cpp:815: Missing spaces around >> [whitespace/operators] [3] Source/WebKit2/WebProcess/WebProcess.cpp:816: Missing spaces around >> [whitespace/operators] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2013-08-01 00:42:59 PDT
Comment on attachment 207902 [details] Patch This patch is incorrect. If the string is 8-bit, you will now execute the second addCharacters call as well.
Kwang Yul Seo
Comment 4 2013-08-01 00:45:45 PDT
Created attachment 207903 [details] Patch
Kwang Yul Seo
Comment 5 2013-08-01 00:47:01 PDT
(In reply to comment #3) > (From update of attachment 207902 [details]) > This patch is incorrect. > If the string is 8-bit, you will now execute the second addCharacters call as well. Thanks for the quick review. I noticed it too and uploaded a new patch.
WebKit Commit Bot
Comment 6 2013-08-01 00:47:55 PDT
Attachment 207903 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1 Source/WebKit2/WebProcess/WebProcess.cpp:815: Missing spaces around >> [whitespace/operators] [3] Source/WebKit2/WebProcess/WebProcess.cpp:818: Missing spaces around >> [whitespace/operators] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kwang Yul Seo
Comment 7 2013-08-01 00:51:33 PDT
(In reply to comment #6) > Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/WebProcess/WebProcess.cpp']" exit_code: 1 > Source/WebKit2/WebProcess/WebProcess.cpp:815: Missing spaces around >> [whitespace/operators] [3] > Source/WebKit2/WebProcess/WebProcess.cpp:818: Missing spaces around >> [whitespace/operators] [3] > Total errors found: 2 in 2 files > > > If any of these errors are false positives, please file a bug against check-webkit-style. BTW, check-webkit-style does not recognize a template within a template (no space between ending >>). We should file a bug to fix this because now we compile everything in C++11 mode.
Kwang Yul Seo
Comment 8 2013-08-01 14:49:46 PDT
Comment on attachment 207903 [details] Patch Clearing flags on attachment: 207903 Committed r153611: <http://trac.webkit.org/changeset/153611>
Kwang Yul Seo
Comment 9 2013-08-01 14:49:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.