Summary: | Reloading this video test shows garbage briefly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
Component: | Layout and Rendering | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | buildbot, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, kondapallykalyan, rniwa, simon.fraser | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
URL: | http://trac.webkit.org/export/153570/trunk/LayoutTests/compositing/overflow/overflow-compositing-descendant.html | ||||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2013-07-31 23:08:46 PDT
RenderVideo::foregroundIsKnownToBeOpaqueInRect() lies. It needs to ask the media player if it's actually going to show anything. Created attachment 209318 [details]
Patch
Comment on attachment 209318 [details] Patch Attachment 209318 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1393100 New failing tests: fast/workers/termination-with-port-messages.html Created attachment 209341 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Comment on attachment 209318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209318&action=review > Source/WebCore/rendering/RenderVideo.cpp:350 > + MediaPlayer* player = mediaElement()->player(); > + if (player) I'd put these on the same line. |