Summary: | webkit-gtk fails to build with bison-3.0 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jeremy Huddleston Sequoia <jeremyhu> | ||||
Component: | WebKitGTK | Assignee: | Zan Dobersek <zan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | allan.jensen, commit-queue, contact, dino, gustavo, kondapallykalyan, mrobinson, sergio, zan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 119892 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Jeremy Huddleston Sequoia
2013-07-31 19:16:20 PDT
Confirmed. There are already generated glslang_tab.cpp and glslang_tab.h files in the ANGLE directory, produced by Bison 2.7[1]. The third-party sources have these two files regenerated with Bison 2.3, for Mac port's purposes. The GTK port regenerates these with the Bison it finds during the configuration. With Bison 3.0, the generated files are causing compilation errors. Could the GTK port switch to building the files that were generated with Bison 2.3, just like the Mac port? Also, only the GTK port generates and compiles the glslang.cpp file, so this part could possibly be removed. [1] https://code.google.com/p/angleproject/source/browse/src/compiler/glslang_tab.cpp Created attachment 208140 [details]
Patch
Comment on attachment 208140 [details]
Patch
LGTM
Comment on attachment 208140 [details] Patch Clearing flags on attachment: 208140 Committed r153749: <http://trac.webkit.org/changeset/153749> All reviewed patches have been landed. Closing bug. I patched glslang.y for bison 3 in bug #119798 so after landing that you might be able to revert this patch. (In reply to comment #6) > I patched glslang.y for bison 3 in bug #119798 so after landing that you might be able to revert this patch. Do you perhaps plan to upstream the fix into ANGLE itself? And thanks for the notice. (In reply to comment #7) > (In reply to comment #6) > > I patched glslang.y for bison 3 in bug #119798 so after landing that you might be able to revert this patch. > > Do you perhaps plan to upstream the fix into ANGLE itself? > And thanks for the notice. I wasn't planning on upstreaming it, but I will take a look now. I was just trying to fix the Qt build in the cleanest possible way. Re-opened since this is blocked by bug 119892 The revision was merged into the webkit-2.0 branch, but should stay there as the ANGLE third-party source has been updated since the branching, so merging the source generation fix into the branch would be a bit risky. Closing again. |