Bug 119365

Summary: [BlackBerry] Page scrolls when width equals device width and initial scale is greater than 0.92
Product: WebKit Reporter: Jacky Jiang <jkjiang>
Component: WebKit BlackBerryAssignee: Jacky Jiang <jkjiang>
Status: RESOLVED FIXED    
Severity: Normal CC: rwlbuis, staikos, tonikitoo, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch rwlbuis: review+

Description Jacky Jiang 2013-07-31 17:53:14 PDT 
JIRA 445423.
Comment 1 Jacky Jiang 2013-07-31 18:22:56 PDT 
Created attachment 207891 [details]
Patch
Comment 2 Rob Buis 2013-07-31 18:34:59 PDT 
Comment on attachment 207891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207891&action=review

Looks good in general.

> Source/WebKit/blackberry/Api/WebPage.cpp:1704
> +    float idealContentsHeight = static_cast<float>(this->transformedActualVisibleSize().height()) / devicePixelRatio;

Are you sure this-> is needed here?

> Source/WebKit/blackberry/Api/WebPage.cpp:1708
> +    return false;

You could replace the if with a return, and then you don't need the return false; statement.
Comment 3 Jacky Jiang 2013-07-31 18:41:43 PDT 
Comment on attachment 207891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207891&action=review

>> Source/WebKit/blackberry/Api/WebPage.cpp:1704
>> +    float idealContentsHeight = static_cast<float>(this->transformedActualVisibleSize().height()) / devicePixelRatio;
> 
> Are you sure this-> is needed here?

Oops, it's not needed. Previously I was writing something like "transformedActualVisibleSize = this->transformedActualVisibleSize()" and I forgot to remove "this" when I changed the code. 
I will remove it.

>> Source/WebKit/blackberry/Api/WebPage.cpp:1708
>> +    return false;
> 
> You could replace the if with a return, and then you don't need the return false; statement.

Good idea. Will update.
Comment 4 Jacky Jiang 2013-07-31 19:00:31 PDT 
Created attachment 207894 [details]
Patch
Comment 5 Rob Buis 2013-07-31 19:05:03 PDT 
Comment on attachment 207894 [details]
Patch

Excellent! :)
Comment 6 Jacky Jiang 2013-07-31 19:21:02 PDT 
Committed r153562: <http://trac.webkit.org/changeset/153562>