Bug 119352

Summary: Make ActiveDOMObject overrides private
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, gyuyoung.kim, rego+ews, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
sam: review+, eflews.bot: commit-queue-
patch for landing none

Alexey Proskuryakov
Reported 2013-07-31 14:20:05 PDT
There is no need to call these through derived classes. And it's quite harmful for anyone except for ScriptExecutionContext to call suspend/resume in particular - ScriptExecutionContext won't know, and it will try to manage the state on its own.
Attachments
proposed patch (18.95 KB, patch)
2013-07-31 14:22 PDT, Alexey Proskuryakov 		sam: review+
eflews.bot: commit-queue-
DetailsFormatted DiffDiff
patch for landing (17.94 KB, patch)
2013-07-31 15:40 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2013-07-31 14:22:48 PDT
Created attachment 207876 [details] proposed patch
EFL EWS Bot
Comment 2 2013-07-31 15:28:39 PDT
Comment on attachment 207876 [details] proposed patch Attachment 207876 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1292787
Alexey Proskuryakov
Comment 3 2013-07-31 15:40:24 PDT
Created attachment 207882 [details] patch for landing Kept public hasPendingActivity() where generated JS bindings needs it.
WebKit Commit Bot
Comment 4 2013-07-31 17:20:19 PDT
Comment on attachment 207882 [details] patch for landing Clearing flags on attachment: 207882 Committed r153551: <http://trac.webkit.org/changeset/153551>
WebKit Commit Bot
Comment 5 2013-07-31 17:20:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.