Summary: | [Windows] Winlauncher shouldn't look for Safari Install Directory | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Tools / Tests | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Brent Fulgham
2013-07-31 14:17:06 PDT
Created attachment 207877 [details]
Patch
Comment on attachment 207877 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207877&action=review > Tools/win/DLLLauncher/DLLLauncherMain.cpp:124 > +static bool directoryExists(wstring path) I suggest const wstring& here. (In reply to comment #2) > (From update of attachment 207877 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207877&action=review > > > Tools/win/DLLLauncher/DLLLauncherMain.cpp:124 > > +static bool directoryExists(wstring path) > > I suggest const wstring& here. Ah! Missed that. Thanks! Committed r153544: <http://trac.webkit.org/changeset/153544> |