| Summary: | SVGPathSeg* JS bindings have live update issues | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||
| Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | eric, rwlbuis | ||||
| Priority: | P2 | ||||||
| Version: | 420+ | ||||||
| Hardware: | Mac | ||||||
| OS: | OS X 10.4 | ||||||
| Attachments: |
|
||||||
Created attachment 11970 [details]
Initial patch
Comment on attachment 11970 [details]
Initial patch
looks fine
|
Adding/removing SVGPathSeg* items to a SVGPathElement (through SVGPathSegList interface) has live updates problems, as the notifyAttributeChange() function isn't called anywhere. The context param is currently stored per SVGPathSeg, which is not needed - as it can be done using SVGPathSegList completely. It wastes memory, that is fixed. In order to get rid of the context param in SVGPathSeg, we need a way to map SVGPathSeg* objects to SVGStyledElement* objects ("context element"). That is done using a new HashMap in the SVGDocumentExtensions class. Attaching patch soon.