Bug 11934

Summary: SVGPathSeg* JS bindings have live update issues
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, rwlbuis
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Initial patch rwlbuis: review+

Nikolas Zimmermann
Reported 2006-12-22 11:23:06 PST
Adding/removing SVGPathSeg* items to a SVGPathElement (through SVGPathSegList interface) has live updates problems, as the notifyAttributeChange() function isn't called anywhere. The context param is currently stored per SVGPathSeg, which is not needed - as it can be done using SVGPathSegList completely. It wastes memory, that is fixed. In order to get rid of the context param in SVGPathSeg, we need a way to map SVGPathSeg* objects to SVGStyledElement* objects ("context element"). That is done using a new HashMap in the SVGDocumentExtensions class. Attaching patch soon.
Attachments
Initial patch (109.95 KB, patch)
2006-12-22 11:25 PST, Nikolas Zimmermann 		rwlbuis: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2006-12-22 11:25:23 PST
Created attachment 11970 [details] Initial patch
Rob Buis
Comment 2 2006-12-22 11:52:30 PST
Comment on attachment 11970 [details] Initial patch looks fine
Nikolas Zimmermann
Comment 3 2006-12-22 11:53:22 PST
Landed in r18393.
Note You need to log in before you can comment on or make changes to this bug.