Bug 11934 - SVGPathSeg* JS bindings have live update issues
Summary: SVGPathSeg* JS bindings have live update issues
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
Depends on:
Reported: 2006-12-22 11:23 PST by Nikolas Zimmermann
Modified: 2006-12-22 11:53 PST (History)
2 users (show)

See Also:

Initial patch (109.95 KB, patch)
2006-12-22 11:25 PST, Nikolas Zimmermann
rwlbuis: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2006-12-22 11:23:06 PST
Adding/removing SVGPathSeg* items to a SVGPathElement (through SVGPathSegList interface) has live updates problems, as the notifyAttributeChange() function isn't called anywhere. The context param is currently stored per SVGPathSeg, which is not needed - as it can be done using SVGPathSegList completely. It wastes memory, that is fixed. In order to get rid of the context param in SVGPathSeg, we need a way to map SVGPathSeg* objects to SVGStyledElement* objects ("context element"). That is done using a new HashMap in the SVGDocumentExtensions class.

Attaching patch soon.
Comment 1 Nikolas Zimmermann 2006-12-22 11:25:23 PST
Created attachment 11970 [details]
Initial patch
Comment 2 Rob Buis 2006-12-22 11:52:30 PST
Comment on attachment 11970 [details]
Initial patch

looks fine
Comment 3 Nikolas Zimmermann 2006-12-22 11:53:22 PST
Landed in r18393.