Bug 119336

Summary: [Qt] ASSERTS trigger in release builds
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: WebKit QtAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, commit-queue, jturcotte, vestbo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Allan Sandfeld Jensen 2013-07-31 05:03:00 PDT
Recently I have started hitting asserts when doing debug_and_release or release builds. It appears NDEBUG is not defined.
Comment 1 Allan Sandfeld Jensen 2013-07-31 05:06:13 PDT
Created attachment 207838 [details]
Patch
Comment 2 Allan Sandfeld Jensen 2013-07-31 05:20:28 PDT
Comment on attachment 207838 [details]
Patch

I am being told this is wrong, and the old test should still work.
Comment 3 Allan Sandfeld Jensen 2013-07-31 05:32:33 PDT
It seems the build can end up being neither release nor debug according to qmake.
Comment 4 Allan Sandfeld Jensen 2013-07-31 05:36:20 PDT
Created attachment 207841 [details]
Patch
Comment 5 Allan Sandfeld Jensen 2013-07-31 05:48:33 PDT
Comment on attachment 207841 [details]
Patch

Clearing flags on attachment: 207841

Committed r153519: <http://trac.webkit.org/changeset/153519>
Comment 6 Allan Sandfeld Jensen 2013-07-31 05:48:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Tor Arne Vestbø 2013-07-31 06:47:49 PDT
Comment on attachment 207841 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207841&action=review

> Tools/qmake/mkspecs/features/default_post.prf:32
> +        !debug:!release: CONFIG += release

This seems dubious. Why are we missing a config in the first place?