Bug 119336

Summary: [Qt] ASSERTS trigger in release builds
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: WebKit QtAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, commit-queue, jturcotte, vestbo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Allan Sandfeld Jensen
Reported 2013-07-31 05:03:00 PDT
Recently I have started hitting asserts when doing debug_and_release or release builds. It appears NDEBUG is not defined.
Attachments
Patch (1.23 KB, patch)
2013-07-31 05:06 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Patch (1.55 KB, patch)
2013-07-31 05:36 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-07-31 05:06:13 PDT
Created attachment 207838 [details] Patch
Allan Sandfeld Jensen
Comment 2 2013-07-31 05:20:28 PDT
Comment on attachment 207838 [details] Patch I am being told this is wrong, and the old test should still work.
Allan Sandfeld Jensen
Comment 3 2013-07-31 05:32:33 PDT
It seems the build can end up being neither release nor debug according to qmake.
Allan Sandfeld Jensen
Comment 4 2013-07-31 05:36:20 PDT
Created attachment 207841 [details] Patch
Allan Sandfeld Jensen
Comment 5 2013-07-31 05:48:33 PDT
Comment on attachment 207841 [details] Patch Clearing flags on attachment: 207841 Committed r153519: <http://trac.webkit.org/changeset/153519>
Allan Sandfeld Jensen
Comment 6 2013-07-31 05:48:38 PDT
All reviewed patches have been landed. Closing bug.
Tor Arne Vestbø
Comment 7 2013-07-31 06:47:49 PDT
Comment on attachment 207841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207841&action=review > Tools/qmake/mkspecs/features/default_post.prf:32 > + !debug:!release: CONFIG += release This seems dubious. Why are we missing a config in the first place?
Note You need to log in before you can comment on or make changes to this bug.