Summary: | REGRESSION: trying to change a property in a computed style declaration results in a crash | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||
Component: | CSS | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | ggaren | ||||
Priority: | P1 | Keywords: | Regression | ||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
Alexey Proskuryakov
2006-12-22 10:35:26 PST
Created attachment 11971 [details]
proposed fix
Comment on attachment 11971 [details]
proposed fix
r=me
That assertion has proven helpful in the past, so it might be useful to assert "has stylesheet or is computedStyleDeclaration." Just a thought. (In reply to comment #3) > That assertion has proven helpful in the past, so it might be useful to assert > "has stylesheet or is computedStyleDeclaration." Just a thought. I also thought so, but couldn't find any way to tell that a style declaration is a computed one. Is there any? Adding a new virtual function for the sake of an assertion seemed a bit too much to me. Agreed. I can't see a good way to do what I suggested. Committed revision 18406, although this code will be rewritten soon, because enabling exceptions for invalid CSS turned out to be too dangerous for compatibility. |