Bug 119319
| Summary: | Don't use Vector<UChar> to build strings | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Web Template Framework | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | benjamin, darin, ggaren, kling, koivisto, msaboff, tonikitoo, webkit-bug-importer |
| Priority: | P2 | Keywords: | BlinkMergeCandidate, InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/9fda929af533c3c1aa3961c4818ea30ed7499021
This CL removes a bunch of code sites that were using Vector<UChar> to
construct strings. That used to be a good way to construct strings, but in the
modern world, we have much better alternatives in the form of StringBuffer and
StringBuilder. (You should use StringBuffer if you know exactly how much memory
you need and you should use StringBuilder if you require a variable amount of
memory.)
This CL removes more clients of the StringImpl pointer. There are still a few
left, which require more study.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
Pull request: https://github.com/WebKit/WebKit/pull/3518
EWS
Committed 258081@main (6b1eb391bf3d): <https://commits.webkit.org/258081@main>
Reviewed commits have been landed. Closing PR #7827 and removing active labels.
Radar WebKit Bug Importer
<rdar://problem/103514934>