Bug 119317

Summary: Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Simon Fraser (smfr)
Reported 2013-07-30 21:31:00 PDT
Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
Attachments
Patch (1.90 KB, patch)
2013-07-30 21:33 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2013-07-30 21:33:52 PDT
Created attachment 207807 [details] Patch
WebKit Commit Bot
Comment 2 2013-08-07 19:12:05 PDT
Comment on attachment 207807 [details] Patch Clearing flags on attachment: 207807 Committed r153811: <http://trac.webkit.org/changeset/153811>
WebKit Commit Bot
Comment 3 2013-08-07 19:12:08 PDT
All reviewed patches have been landed. Closing bug.
Benjamin Poulain
Comment 4 2013-08-11 22:20:17 PDT
This is really cool! Why did you need the timeout? Wouldn't CFRunLoopStop(CFRunLoopGetMain()); exit the loop?
Simon Fraser (smfr)
Comment 5 2013-08-12 20:35:20 PDT
I didn't really need to timeout, but it was a failsafe in case we relied on some other side effect of the old behavior.
Note You need to log in before you can comment on or make changes to this bug.