Bug 119317

Summary: Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, mitz, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Simon Fraser (smfr) 2013-07-30 21:31:00 PDT
Allow the DumpRenderTree runloop to be idle while waiting for a test to complete
Comment 1 Simon Fraser (smfr) 2013-07-30 21:33:52 PDT
Created attachment 207807 [details]
Patch
Comment 2 WebKit Commit Bot 2013-08-07 19:12:05 PDT
Comment on attachment 207807 [details]
Patch

Clearing flags on attachment: 207807

Committed r153811: <http://trac.webkit.org/changeset/153811>
Comment 3 WebKit Commit Bot 2013-08-07 19:12:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Benjamin Poulain 2013-08-11 22:20:17 PDT
This is really cool!

Why did you need the timeout? Wouldn't CFRunLoopStop(CFRunLoopGetMain()); exit the loop?
Comment 5 Simon Fraser (smfr) 2013-08-12 20:35:20 PDT
I didn't really need to timeout, but it was a failsafe in case we relied on some other side effect of the old behavior.