Bug 119298

Summary: JSOESTextureHalfFloat not generated on Windows
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Alex Christensen 2013-07-30 18:14:03 PDT
I have spent weeks wondering why OESTextureHalfFloat wasn't working on Windows.  JSOESTextureHalfFloat.h and JSOESTextureHalfFloat.cpp were not being generated.  After going through every possible difference between OESTextureHalfFloat and OESTextureFloat I found the problem: OESTextureHalfFloat.idl doesn't end with a newline, which was making generate-bindings.pl fail, but only on Windows.
Comment 1 Alex Christensen 2013-07-30 18:19:00 PDT
Created attachment 207793 [details]
Patch
Comment 2 Chris Dumez 2013-07-30 22:24:41 PDT
Comment on attachment 207793 [details]
Patch

r=me.
Comment 3 WebKit Commit Bot 2013-08-01 09:52:38 PDT
Comment on attachment 207793 [details]
Patch

Clearing flags on attachment: 207793

Committed r153588: <http://trac.webkit.org/changeset/153588>
Comment 4 WebKit Commit Bot 2013-08-01 09:52:40 PDT
All reviewed patches have been landed.  Closing bug.