Summary: | wrong static_casts in ANGLE | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Major | CC: | commit-queue, dino, eric.carlson, glenn, jer.noble, kondapallykalyan | ||||||
Priority: | P1 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Alex Christensen
2013-07-30 17:16:17 PDT
Created attachment 207789 [details]
Patch
Attachment 207789 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp', u'Source/ThirdParty/ANGLE/src/compiler/intermediate.h']" exit_code: 1
Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp:1406: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 207790 [details]
Patch
Attachment 207790 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/ThirdParty/ANGLE/ChangeLog', u'Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp', u'Source/ThirdParty/ANGLE/src/compiler/intermediate.h']" exit_code: 1
Source/ThirdParty/ANGLE/src/compiler/Intermediate.cpp:1406: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 207790 [details] Patch Clearing flags on attachment: 207790 Committed r153600: <http://trac.webkit.org/changeset/153600> All reviewed patches have been landed. Closing bug. |