Bug 119282

Summary: revalidateTiles and ensureTilesForRect can share a lot of code
Product: WebKit Reporter: Tim Horton <thorton>
Component: Layout and RenderingAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
take one
none
take two
none
patch simon.fraser: review+

Tim Horton
Reported 2013-07-30 15:28:56 PDT
They share lots of code, but it's kind of scary to change these.
Attachments
take one (7.21 KB, patch)
2013-07-30 15:29 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
take two (7.46 KB, patch)
2013-08-07 17:26 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
patch (8.96 KB, patch)
2013-08-15 17:53 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-07-30 15:29:20 PDT
Created attachment 207774 [details] take one
Tim Horton
Comment 2 2013-08-07 17:26:09 PDT
Created attachment 208306 [details] take two needs a change log but I have to go fix something else, attaching new patch for now
Tim Horton
Comment 3 2013-08-15 17:53:12 PDT
Created attachment 208872 [details] patch
Simon Fraser (smfr)
Comment 4 2013-08-16 17:32:50 PDT
Comment on attachment 208872 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=208872&action=review > Source/WebCore/platform/graphics/ca/mac/TileController.h:149 > + enum class NewTileType { PrimaryTiles, SecondaryTiles }; Maybe CoverageType? > Source/WebCore/platform/graphics/ca/mac/TileController.h:150 > + IntRect ensureTilesForRect(const FloatRect&, NewTileType); What does the return value mean?
Tim Horton
Comment 5 2013-08-21 14:04:01 PDT
http://trac.webkit.org/changeset/154413
Tim Horton
Comment 6 2013-08-21 14:07:57 PDT
and http://trac.webkit.org/changeset/154415
Note You need to log in before you can comment on or make changes to this bug.