Bug 119279

Summary: Speculative fix for crash due to string access on multiple threads
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: WebKit2Assignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Anders Carlsson
Reported 2013-07-30 14:46:28 PDT
Speculative fix for crash due to string access on multiple threads
Attachments
Patch (3.79 KB, patch)
2013-07-30 14:53 PDT, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-07-30 14:53:47 PDT
Created attachment 207768 [details] Patch
Anders Carlsson
Comment 2 2013-07-30 15:19:14 PDT
Committed r153499: <http://trac.webkit.org/changeset/153499>
Darin Adler
Comment 3 2013-07-30 21:14:52 PDT
Comment on attachment 207768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207768&action=review > Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:56 > + RefPtr<StringImpl> copiedLocalStorageDirectory = localStorageDirectory.impl() ? localStorageDirectory.impl()->isolatedCopy() : nullptr; Is this really better than: RefPtr<StringImpl> copiedLocalStorageDirectory = localStorageDirectory.isolatedCopy().impl(); ? Wish I had thought of that before you landed it.
Note You need to log in before you can comment on or make changes to this bug.