Bug 119279

Summary: Speculative fix for crash due to string access on multiple threads
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: WebKit2Assignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch darin: review+

Description Anders Carlsson 2013-07-30 14:46:28 PDT 
Speculative fix for crash due to string access on multiple threads
Comment 1 Anders Carlsson 2013-07-30 14:53:47 PDT 
Created attachment 207768 [details]
Patch
Comment 2 Anders Carlsson 2013-07-30 15:19:14 PDT 
Committed r153499: <http://trac.webkit.org/changeset/153499>
Comment 3 Darin Adler 2013-07-30 21:14:52 PDT 
Comment on attachment 207768 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207768&action=review

> Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp:56
> +    RefPtr<StringImpl> copiedLocalStorageDirectory = localStorageDirectory.impl() ? localStorageDirectory.impl()->isolatedCopy() : nullptr;

Is this really better than:

    RefPtr<StringImpl> copiedLocalStorageDirectory = localStorageDirectory.isolatedCopy().impl();

? Wish I had thought of that before you landed it.