Summary: | [WebKit2] [Gtk] WebKitResponsePolicyDecision URI response property incorrect | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brian Holt <brian.holt> | ||||||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | cgarcia, commit-queue, gustavo, mrobinson | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Brian Holt
2013-07-30 07:28:26 PDT
Created attachment 207736 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 207736 [details]
Patch
Cancelling review: in eclipse I couldn't see the _ that preceded the parentheses. Apologies.
Created attachment 207737 [details]
Patch
Comment on attachment 207737 [details]
Patch
Thanks for the review! Setting CQ?
Comment on attachment 207737 [details]
Patch
What was wrong here? just the coding style?
Comment on attachment 207737 [details]
Patch
Ah I see we were using WEBKIT_TYPE_URI_REQUEST instead of WEBKIT_TYPE_URI_RESPONSE, the change was hidden in the conding style "fixes". Please explain what you are fixing in the changelog before landing this.
(In reply to comment #7) > (From update of attachment 207737 [details]) > Ah I see we were using WEBKIT_TYPE_URI_REQUEST instead of WEBKIT_TYPE_URI_RESPONSE, the change was hidden in the conding style "fixes". Please explain what you are fixing in the changelog before landing this. Sorry Carlos, I though my comment in the changeLog "Corrected the installed URI response property" was sufficient but I'll expand on that a bit more. Its definitely not just a style change :-) Created attachment 207738 [details]
Updated Patch
(In reply to comment #8) > (In reply to comment #7) > > (From update of attachment 207737 [details] [details]) > > Ah I see we were using WEBKIT_TYPE_URI_REQUEST instead of WEBKIT_TYPE_URI_RESPONSE, the change was hidden in the conding style "fixes". Please explain what you are fixing in the changelog before landing this. > > Sorry Carlos, I though my comment in the changeLog "Corrected the installed URI response property" was sufficient but I'll expand on that a bit more. Its definitely not just a style change :-) That says there's something wrong, but not what, it took me a while to find what was wrong. Thanks for updating it. (In reply to comment #9) > Created an attachment (id=207738) [details] > Updated Patch When submitting an updated patch that has already been r+'ed, you can upload the patch with the reviewer line filled, and only ask for commit-queue. Note that I didn't r- the patch, just cq-. Created attachment 207739 [details]
Updated Patch
Comment on attachment 207739 [details]
Updated Patch
Excellent, thanks!
Thanks for pointing that out Carlos. It took me a moment to find the actual issue. And thanks Brian for fixing it. :) Comment on attachment 207739 [details] Updated Patch Clearing flags on attachment: 207739 Committed r153479: <http://trac.webkit.org/changeset/153479> All reviewed patches have been landed. Closing bug. |