Bug 119251

Summary: Pass column as 4th argument to WorkerGlobalScope.onerror and Window.onerror handlers
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, arv, benjamin, commit-queue, darin, esprehn+autocc, ggaren, kangil.han, laszlo.gombos, mkwst
Priority: P2 Keywords: BlinkMergeCandidate, WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#onerroreventhandler
Bug Depends on:    
Bug Blocks: 119257    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2013-07-30 06:17:37 PDT
As per the latest WebWorker specification, the WorkerGlobalScope.onerror and Window.onerror event handlers should be given the column as fourth argument: http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#workerglobalscope http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#onerroreventhandler This is already supported by IE10 and Blink. Corresponding Blink revision: https://src.chromium.org/viewvc/blink?revision=154630&view=revision Test case: http://samples.msdn.microsoft.com/ietestcenter/WebWorkers/webworkers_harness.htm?url=WorkerGlobalScope_ErrorEvent_colno.htm
Attachments
Patch (32.03 KB, patch)
2013-07-30 07:00 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (32.02 KB, patch)
2013-07-30 07:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-07-30 07:00:15 PDT
Created attachment 207733 [details] Patch
Chris Dumez
Comment 2 2013-07-30 07:07:28 PDT
Created attachment 207734 [details] Patch
Geoffrey Garen
Comment 3 2013-07-30 09:07:50 PDT
Comment on attachment 207734 [details] Patch r=me
WebKit Commit Bot
Comment 4 2013-07-30 10:37:45 PDT
Comment on attachment 207734 [details] Patch Clearing flags on attachment: 207734 Committed r153480: <http://trac.webkit.org/changeset/153480>
WebKit Commit Bot
Comment 5 2013-07-30 10:37:48 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.