Bug 119250

Summary:

[Coordinated Graphics] Use m_ prefix only for member variable

Product:

WebKit

Reporter:

Jae Hyun Park <jaepark>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, commit-queue, kondapallykalyan, luiz, noam

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	noam: review+, noam: commit-queue-
Patch	none
Patch	none
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion	none

Jae Hyun Park

Reported 2013-07-30 05:35:16 PDT

Patch to follow.

Attachments
Patch (2.12 KB, patch) 2013-07-30 05:37 PDT, Jae Hyun Park	noam: review+ noam: commit-queue-	Details Formatted Diff Diff
Patch (3.04 KB, patch) 2013-07-30 18:15 PDT, Jae Hyun Park	no flags	Details Formatted Diff Diff
Patch (3.02 KB, patch) 2013-07-31 01:22 PDT, Jae Hyun Park	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion (710.80 KB, application/zip) 2013-07-31 04:07 PDT, WebKit Commit Bot	no flags	Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Jae Hyun Park

Comment 1 2013-07-30 05:37:10 PDT

Created attachment 207727 [details] Patch

Noam Rosenthal

Comment 2 2013-07-30 05:48:23 PDT

Comment on attachment 207727 [details] Patch can you change the class parameters to be const& while at it?

Jae Hyun Park

Comment 3 2013-07-30 18:15:25 PDT

Created attachment 207792 [details] Patch

Noam Rosenthal

Comment 4 2013-07-31 01:07:34 PDT

Comment on attachment 207792 [details] Patch Please const& only for class types... programType and meshType are enums.

Jae Hyun Park

Comment 5 2013-07-31 01:22:46 PDT

Created attachment 207817 [details] Patch

Jae Hyun Park

Comment 6 2013-07-31 01:23:04 PDT

(In reply to comment #4) > (From update of attachment 207792 [details]) > Please const& only for class types... programType and meshType are enums. Oops... sorry. Thanks for the review!

WebKit Commit Bot

Comment 7 2013-07-31 04:07:17 PDT

Comment on attachment 207817 [details] Patch Rejecting attachment 207817 [details] from commit-queue. New failing tests: compositing/reflections/load-video-in-reflection.html Full output: http://webkit-queues.appspot.com/results/1295664

WebKit Commit Bot

Comment 8 2013-07-31 04:07:19 PDT

Created attachment 207831 [details] Archive of layout-test-results from webkit-cq-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-mountainlion Platform: Mac OS X 10.8.3

WebKit Commit Bot

Comment 9 2013-07-31 09:06:45 PDT

Comment on attachment 207817 [details] Patch Clearing flags on attachment: 207817 Committed r153523: <http://trac.webkit.org/changeset/153523>

WebKit Commit Bot

Comment 10 2013-07-31 09:06:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.