| Summary: | [Coordinated Graphics] Use m_ prefix only for member variable | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jae Hyun Park <jaepark> | ||||||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, kondapallykalyan, luiz, noam | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Jae Hyun Park
2013-07-30 05:35:16 PDT
Created attachment 207727 [details]
Patch
Comment on attachment 207727 [details]
Patch
can you change the class parameters to be const& while at it?
Created attachment 207792 [details]
Patch
Comment on attachment 207792 [details]
Patch
Please const& only for class types... programType and meshType are enums.
Created attachment 207817 [details]
Patch
(In reply to comment #4) > (From update of attachment 207792 [details]) > Please const& only for class types... programType and meshType are enums. Oops... sorry. Thanks for the review! Comment on attachment 207817 [details] Patch Rejecting attachment 207817 [details] from commit-queue. New failing tests: compositing/reflections/load-video-in-reflection.html Full output: http://webkit-queues.appspot.com/results/1295664 Created attachment 207831 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Comment on attachment 207817 [details] Patch Clearing flags on attachment: 207817 Committed r153523: <http://trac.webkit.org/changeset/153523> All reviewed patches have been landed. Closing bug. |