Bug 119247

Summary:

[WIN] Remove dependency on CoreFoundation from DownloadBundle

Product:

WebKit

Reporter:

Patrick R. Gansterer <paroga>

Component:

Platform

Assignee:

Patrick R. Gansterer <paroga>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, galpeter

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch	none
Patch	none

Description Patrick R. Gansterer 2013-07-30 05:21:18 PDT

[WIN] Remove dependecy on CoreFoundation from DownloadBundle

Comment 1 Patrick R. Gansterer 2013-07-30 05:28:09 PDT

Created attachment 207723 [details]
Patch

Comment 2 WebKit Commit Bot 2013-07-30 05:30:12 PDT

Attachment 207723 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/cf/DownloadBundle.h', u'Source/WebCore/platform/network/curl/DownloadBundle.h', u'Source/WebCore/platform/network/win/DownloadBundleWin.cpp', u'Source/WebKit/win/WebDownloadCFNet.cpp']" exit_code: 1
Source/WebKit/win/WebDownloadCFNet.cpp:174:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Patrick R. Gansterer 2013-07-30 05:35:59 PDT

Created attachment 207726 [details]
Patch

Comment 4 WebKit Commit Bot 2013-07-30 11:59:55 PDT

Comment on attachment 207726 [details]
Patch

Clearing flags on attachment: 207726

Committed r153485: <http://trac.webkit.org/changeset/153485>

Comment 5 WebKit Commit Bot 2013-07-30 11:59:57 PDT

All reviewed patches have been landed.  Closing bug.