Bug 119247

Summary: [WIN] Remove dependency on CoreFoundation from DownloadBundle
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: PlatformAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, galpeter
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch none

Patrick R. Gansterer
Reported 2013-07-30 05:21:18 PDT
[WIN] Remove dependecy on CoreFoundation from DownloadBundle
Attachments
Patch (8.83 KB, patch)
2013-07-30 05:28 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (8.83 KB, patch)
2013-07-30 05:35 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2013-07-30 05:28:09 PDT
Created attachment 207723 [details] Patch
WebKit Commit Bot
Comment 2 2013-07-30 05:30:12 PDT
Attachment 207723 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/platform/network/cf/DownloadBundle.h', u'Source/WebCore/platform/network/curl/DownloadBundle.h', u'Source/WebCore/platform/network/win/DownloadBundleWin.cpp', u'Source/WebKit/win/WebDownloadCFNet.cpp']" exit_code: 1 Source/WebKit/win/WebDownloadCFNet.cpp:174: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Patrick R. Gansterer
Comment 3 2013-07-30 05:35:59 PDT
Created attachment 207726 [details] Patch
WebKit Commit Bot
Comment 4 2013-07-30 11:59:55 PDT
Comment on attachment 207726 [details] Patch Clearing flags on attachment: 207726 Committed r153485: <http://trac.webkit.org/changeset/153485>
WebKit Commit Bot
Comment 5 2013-07-30 11:59:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.